-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump golang.org/x/crypto to v0.31.0 #29153
Conversation
mitigates CVE-2024-45337 which does not affect Vault but will help reduce scanner noise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but do make sure to backport this to 1.16, 1.17, 1.18 (as per the requirement for any security thing) -- make sure our dependencies are at the same levels too.
CI Results: |
Build Results: |
@VioletHynes would you mind merging this one ? I don't have merge rights on this repo |
Oh, sorry! I thought you did. Will do! |
mitigates CVE-2024-45337 which does not affect Vault but will help reduce scanner noise
Any plans to apply the same fix to |
Are there still plans to backport this to 1.17? |
mitigates CVE-2024-45337 which does not affect Vault (Vault does not use the affected functionality) but will help reduce scanner noise
Description
What does this PR do?
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.