Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow querying of activity APIs during upgrade #29154

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Dec 11, 2024

Description

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@divyaac divyaac requested a review from a team as a code owner December 11, 2024 20:49
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 11, 2024
@divyaac divyaac removed the request for review from paymanblu December 11, 2024 20:49
@divyaac divyaac added this to the 1.19.0-rc milestone Dec 11, 2024
@divyaac divyaac enabled auto-merge (squash) December 11, 2024 20:54
Copy link

CI Results:
All required Go tests succeeded but failures were detected ⚠️
Failures:

Test Type Package Test Logs
race vault/external_tests/raft TestSysHealth_Raft view test results
race vault/external_tests/raft TestSysHealth_Raft/remove_and_unpartition view test results

Copy link

Build Results:
All builds succeeded! ✅

@divyaac divyaac merged commit 46c69d7 into main Dec 11, 2024
95 of 99 checks passed
@divyaac divyaac deleted the VAULT-32509_Disallow_Querying_Activity_Log_Clusters branch December 11, 2024 21:07
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
divyaac added a commit that referenced this pull request Dec 20, 2024
divyaac added a commit that referenced this pull request Dec 20, 2024
divyaac added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants