Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove changelog #29024 #29162

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Dec 11, 2024

Description

What does this PR do?
The PR removes the #29024's unnecessary changelog

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@thyton thyton requested a review from a team as a code owner December 11, 2024 23:07
@thyton thyton requested a review from davidadeleon December 11, 2024 23:07
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 11, 2024
@thyton thyton removed the request for review from davidadeleon December 11, 2024 23:07
@thyton thyton added this to the 1.19.0-rc milestone Dec 11, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

@thyton thyton added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 11, 2024
Copy link

Build Results:
All builds succeeded! ✅

@thyton thyton requested a review from a team December 11, 2024 23:12
@thyton thyton merged commit d956574 into main Dec 12, 2024
53 of 55 checks passed
@thyton thyton deleted the VAULT-30006-remove-unnecessary-changelog branch December 12, 2024 05:09
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants