Sort CA chain into root and intermediates on VerifyCertificate. #29255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
victorr
added
backport/ent/1.16.x+ent
In order for the Certificate.Verify method to work correctly, the certificates in the CA chain need to be sorted into separate root and intermediate certificate pools. Add unit tests to verify that name constraints in both the root and intermediate certificates are checked.
victorr
force-pushed
the
victorr/vault-33182-chained-cert-name-constraints
branch
from
7bd9b95 to
728af4b
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
sgmiller
previously approved these changes
Dec 23, 2024
victorr
force-pushed
the
victorr/vault-33182-chained-cert-name-constraints
branch
from
5524f27 to
43d11bb
Compare
sgmiller
approved these changes
Dec 23, 2024
victorr
deleted the
victorr/vault-33182-chained-cert-name-constraints
branch
6 tasks
victorr
added a commit
that referenced
this pull request
Dec 23, 2024
Sort CA chain into root and intermediates on VerifyCertificate. In order for the Certificate.Verify method to work correctly, the certificates in the CA chain need to be sorted into separate root and intermediate certificate pools. Add unit tests to verify that name constraints in both the root and intermediate certificates are checked.
kitography
pushed a commit
that referenced
this pull request
Jan 3, 2025
Sort CA chain into root and intermediates on VerifyCertificate. In order for the Certificate.Verify method to work correctly, the certificates in the CA chain need to be sorted into separate root and intermediate certificate pools. Add unit tests to verify that name constraints in both the root and intermediate certificates are checked.
victorr
added a commit
that referenced
this pull request
Jan 6, 2025
…) (#29256) Sort CA chain into root and intermediates on VerifyCertificate. In order for the Certificate.Verify method to work correctly, the certificates in the CA chain need to be sorted into separate root and intermediate certificate pools. Add unit tests to verify that name constraints in both the root and intermediate certificates are checked. Co-authored-by: Victor Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order for the Certificate.Verify method to work correctly, the certificates in the CA chain need to be sorted into separate root and intermediate certificate pools.
Add unit tests to verify that name constraints in both the root and intermediate certificates are checked.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.