Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copywrite exceptions to exclude *_ent.go #29315

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Jan 8, 2025

Description

What does this PR do?
This PR updates copywrite-exceptions script to exclude *_ent.go which are not intended for public use

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@thyton thyton requested a review from a team as a code owner January 8, 2025 20:22
@thyton thyton requested a review from divyapola5 January 8, 2025 20:22
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 8, 2025
@thyton thyton added pr/no-changelog pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jan 8, 2025
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thyton thyton enabled auto-merge (squash) January 8, 2025 20:35
Copy link

github-actions bot commented Jan 8, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 8, 2025

Build Results:
All builds succeeded! ✅

@thyton thyton merged commit ad35129 into main Jan 8, 2025
117 of 121 checks passed
@thyton thyton deleted the thyton/VAULT-32686/update-copywrite-exceptions branch January 8, 2025 20:39
@stevendpclark
Copy link
Contributor

Should this have also excluded enterprise test files?

@thyton
Copy link
Contributor Author

thyton commented Jan 8, 2025

My bad and thanks for catching it @stevendpclark! Could you approve #29319?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants