(TFECO-8323) Port UI tests to vscode-extension-tester and remove wdio #1873
+3,777
−16,827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
redhat-ext-tester
branch
3 times, most recently
from
5533551 to
6bc8e54
Compare
jpogran
force-pushed
the
redhat-ext-tester
branch
10 times, most recently
from
04c7403 to
3a4abcb
Compare
jpogran
changed the title
jpogran
force-pushed
the
redhat-ext-tester
branch
4 times, most recently
from
553b9e2 to
a313c46
Compare
jpogran
changed the title
dbanck
reviewed
Nov 25, 2024
jpogran
force-pushed
the
redhat-ext-tester
branch
from
a313c46 to
608d49c
Compare
Closed
jpogran
force-pushed
the
redhat-ext-tester
branch
from
608d49c to
b92ec55
Compare
jpogran
force-pushed
the
redhat-ext-tester
branch
2 times, most recently
from
d3d22c9 to
bd30f6a
Compare
dbanck
previously approved these changes
Dec 4, 2024
This installs the redhat extension tester and removes the wdio test runner and its dependencies from the project. This allows us to test treeviews, which is what the HCP integration uses, locally and in CI in a reliable manner. This is large port of existing UI tests to a new API and it required a new way to run the tests. So a script that runs the tests has been created that will run the tests in a headless mode when running in CI and in a windowed mode when running locally. This is to ensure that the tests can be run in a reliable manner in both environments. It also mocks the HCP API so that the tests can be run without needing to have a connection to HCP infrastructure. A bug in the login workflow was found during this effort. After successfully authenticing, the organization picker was left open and could not be closed. This was fixed by disposing the organization picker after successfully authenticating. Since the primary focus was on the HCP treeview tests (most likely to break when changing this area), the Terraform treeview tests (which have much simpler functionality) were not updated and left for a future PR. This also fixes the issue with the `test.yml` file where the `VSCODE_VERSION` was not being set correctly. This was causing the tests to not actually run with different versions of VSCode. A minor addition to the eslint ruleset to allow for the use of `unsafe` access or `any` in the codebase where it is needed, specifically in places where we interact with libraries that are not typed or where we need to access properties that are not typed.
jpogran
force-pushed
the
redhat-ext-tester
branch
from
f7d6eba to
3a36587
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs the redhat extension tester and removes the wdio test runner and its dependencies from the project. This allows us to test treeviews, which is what the HCP integration uses, locally and in CI in a reliable manner.
This is large port of existing UI tests to a new API and it required a new way to run the tests. So a script that runs the tests has been created that will run the tests in a headless mode when running in CI and in a windowed mode when running locally. This is to ensure that the tests can be run in a reliable manner in both environments. It also mocks the HCP API so that the tests can be run without needing to have a connection to HCP infrastructure.
A bug in the login workflow was found during this effort. After successfully authenticing, the organization picker was left open and could not be closed. This was fixed by disposing the organization picker after successfully authenticating.
Since the primary focus was on the HCP treeview tests (most likely to break when changing this area), the Terraform treeview tests (which have much simpler functionality) were not updated and left for a future PR.
This also fixes the issue with the
test.ymlfile where theVSCODE_VERSIONwas not being set correctly. This was causing the tests to not actually run with different versions of VSCode.A minor addition to the eslint ruleset to allow for the use of
unsafeaccess oranyin the codebase where it is needed, specifically in places where we interact with libraries that are not typed or where we need to access properties that are not typed.