-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODE RUB: Refactor Foundations Test Methods #528
base: master
Are you sure you want to change the base?
Conversation
@hassanhabib |
Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts |
please see The-Standard specifically here you can see that these are verifications that no other calls have been made. |
@glhays It can be written, but it won't do anything. Times.Never because. It's better if we don't write |
@glhays In the projects we do by applying The Standard, we make the same arrangement as I did, and the result is the same @ElbekDeveloper |
yes I understand, I guess my point is that the standard currently calls for it to be written as it currently is. Removing it now may cause others using these projects as learning vesicles, may question why all so different from the published standard. Believe me I am not disputing anything here and I am not the trier of what gets merged was just asking why. |
@glhays Ustad Hassan brings clarity to this issue. We will understand better |
@KhanbalaRashidov FYI see this video for Git verification. |
Thanks |
@KhanbalaRashidov This specific point 1:20:56 of the following video may enlighten your perspective on the redundancy or uneeded verifications within The Standard testing framework. |
Unnecessary codes cleared