Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE RUB: Refactor Foundations Test Methods #528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KhanbalaRashidov
Copy link

Unnecessary codes cleared

@glhays
Copy link
Collaborator

glhays commented Oct 6, 2023

Unnecessary codes cleared

@hassanhabib
@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's. please see The-Standard specifically here you can see that these are verifications that no other calls have been made.
https://github.com/hassanhabib/The-Standard/blob/master/2.%20Services/2.1%20Foundations/2.1%20Foundations.md#213112-rules--validations-collector

@KhanbalaRashidov
Copy link
Author

Unnecessary codes cleared

@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's
@hassanhabib

Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts

@glhays
Copy link
Collaborator

glhays commented Oct 6, 2023

Unnecessary codes cleared

@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's
@hassanhabib

Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts

please see The-Standard specifically here you can see that these are verifications that no other calls have been made.
https://github.com/hassanhabib/The-Standard/blob/master/2.%20Services/2.1%20Foundations/2.1%20Foundations.md#213112-rules--validations-collector

@KhanbalaRashidov
Copy link
Author

Unnecessary codes cleared

@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's
@hassanhabib

Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts

please see The-Standard specifically here you can see that these are verifications that no other calls have been made.
https://github.com/hassanhabib/The-Standard/blob/master/2.%20Services/2.1%20Foundations/2.1%20Foundations.md#213112-rules--validations-collector

@glhays It can be written, but it won't do anything. Times.Never because. It's better if we don't write

@KhanbalaRashidov
Copy link
Author

Unnecessary codes cleared

@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's
@hassanhabib

Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts

please see The-Standard specifically here you can see that these are verifications that no other calls have been made.
https://github.com/hassanhabib/The-Standard/blob/master/2.%20Services/2.1%20Foundations/2.1%20Foundations.md#213112-rules--validations-collector

@glhays It can be written, but it won't do anything. Times.Never because. It's better if we don't write

@glhays In the projects we do by applying The Standard, we make the same arrangement as I did, and the result is the same @ElbekDeveloper

@glhays
Copy link
Collaborator

glhays commented Oct 7, 2023

Unnecessary codes cleared

@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's
@hassanhabib

Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts

please see The-Standard specifically here you can see that these are verifications that no other calls have been made.
https://github.com/hassanhabib/The-Standard/blob/master/2.%20Services/2.1%20Foundations/2.1%20Foundations.md#213112-rules--validations-collector

@glhays It can be written, but it won't do anything. Times.Never because. It's better if we don't write

@glhays In the projects we do by applying The Standard, we make the same arrangement as I did, and the result is the same @ElbekDeveloper

yes I understand, I guess my point is that the standard currently calls for it to be written as it currently is. Removing it now may cause others using these projects as learning vesicles, may question why all so different from the published standard. Believe me I am not disputing anything here and I am not the trier of what gets merged was just asking why.

@KhanbalaRashidov
Copy link
Author

Unnecessary codes cleared

@KhanbalaRashidov Please explain your reasoning for removing verification calls "Never" from all the tests. Which in turn you reorder the VNO's
@hassanhabib

Because the VerifyNoOtherCalls() method does the same thing, we don't need to write the Never parts

please see The-Standard specifically here you can see that these are verifications that no other calls have been made.
https://github.com/hassanhabib/The-Standard/blob/master/2.%20Services/2.1%20Foundations/2.1%20Foundations.md#213112-rules--validations-collector

@glhays It can be written, but it won't do anything. Times.Never because. It's better if we don't write

@glhays In the projects we do by applying The Standard, we make the same arrangement as I did, and the result is the same @ElbekDeveloper

yes I understand, I guess my point is that the standard currently calls for it to be written as it currently is. Removing it now may cause others using these projects as learning vesicles, may question why all so different from the published standard. Believe me I am not disputing anything here and I am not the trier of what gets merged was just asking why.

@glhays Ustad Hassan brings clarity to this issue. We will understand better

@glhays
Copy link
Collaborator

glhays commented Oct 9, 2023

@KhanbalaRashidov FYI see this video for Git verification.
https://youtu.be/u9L5kDlU8rs?si=e0erAk4iD7JK7Zmc

@KhanbalaRashidov
Copy link
Author

@KhanbalaRashidov FYI see this video for Git verification. https://youtu.be/u9L5kDlU8rs?si=e0erAk4iD7JK7Zmc

Thanks

@glhays
Copy link
Collaborator

glhays commented Oct 13, 2023

@KhanbalaRashidov This specific point 1:20:56 of the following video may enlighten your perspective on the redundancy or uneeded verifications within The Standard testing framework.
https://youtu.be/guJPrIQ0kJk?si=Pqvw8IgLPHvOWpUT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants