Skip to content

Commit

Permalink
Add MAINTAINERS document to 4.x branch
Browse files Browse the repository at this point in the history
  • Loading branch information
akrabat committed Apr 18, 2019
1 parent 5f68a6f commit 8946b94
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Maintainers

There aren't many rules for maintainers of Slim to remember; what we have is listed here.

## We don't merge our own PRs

Our code is better if more than one set of eyes looks at it. Therefore we do not merge our own pull requests unless there is an exceptional circumstance. This helps to spot errors in the patch and also enables us to share information about the project around the maintainer team.

## PRs tagged `WIP` are not ready to be merged

Sometimes it's helpful to collaborate on a patch before it's ready to be merged. We use the text `WIP` (for _Work in Progress_) in the title to mark these PRs.

If a PR has `WIP` in its title, then it is not to be merged. The person who raised the PR will remove the `WIP` text when they are ready for a full review and merge.

## Assign a merged PR to a milestone

By ensuring that all merged PRs are assigned to a milestone, we can easily find which PRs were in which release.

0 comments on commit 8946b94

Please sign in to comment.