Implement search_after operator for pagination
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Bilal
force-pushed
the
m-bilal/ent-228-search-after-op
branch
2 times, most recently
from
d294607 to
13e7923
Compare
m-Bilal
force-pushed
the
m-bilal/ent-228-search-after-op
branch
from
13e7923 to
490430e
Compare
m-Bilal
force-pushed
the
m-bilal/ent-228-search-after-op
branch
from
0743118 to
48000f2
Compare
m-Bilal
commented
Jan 23, 2025
|
|
||
| // TODO: disable track_total_hits speeds up the query | ||
| // https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html | ||
| // query["track_total_hits"] = false |
There was a problem hiding this comment.
This has been commented out because this is causing the connector to crash. Once we've delivered search_after, we could pick this up as a part of query optimization
|
Not yet tested with native queries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes ENT-228
Design
search_afterhas been added as an argument to all collectionsReview
search_afterare added in this commit. Please review the test cases (GQL queries) and the resulting Elasticsearch queries (want.json) to verify they're correctsearch_afteris in this commitsearch_afterbeing added as a collection argument and the resulting changes in the/schemaof the connector can be reviewed in this commit