add missing test case

hawkv6 · Jul 15, 2024 · 23138d3 · 23138d3
1 parent 8296474
commit 23138d3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/graph/network_graph.go b/pkg/graph/network_graph.go
@@ -113,7 +113,9 @@ func (graph *NetworkGraph) addNodesToSubgraph(newSubGraphs map[uint32]*NetworkGr
 func (graph *NetworkGraph) addEdgesToSubgraph(newSubGraphs map[uint32]*NetworkGraph) {
 	for _, edge := range graph.edges {
 		for flexAlgo := range edge.GetFlexibleAlgorithms() {
-			_ = newSubGraphs[flexAlgo].AddEdge(edge)
+			if err := newSubGraphs[flexAlgo].AddEdge(edge); err != nil {
+				graph.log.Errorf("Error adding edge to subgraph: %s", err)
+			}
 		}
 	}
 }

diff --git a/pkg/graph/network_graph_test.go b/pkg/graph/network_graph_test.go
@@ -760,6 +760,7 @@ func TestNetworkGraph_addEdgesToSubgraph(t *testing.T) {
 					},
 				),
 			},
+			wantErr: true,
 		},
 	}
 
@@ -773,6 +774,9 @@ func TestNetworkGraph_addEdgesToSubgraph(t *testing.T) {
 			graph.edges = tt.edges
 			newSubGraphs := make(map[uint32]*NetworkGraph)
 			graph.addNodesToSubgraph(newSubGraphs)
+			if tt.wantErr {
+				graph.nodes = nil
+			}
 			graph.addEdgesToSubgraph(newSubGraphs)
 			assert.Equal(t, 2, len(newSubGraphs[128].edges))
 			assert.Equal(t, 0, len(newSubGraphs[129].edges))