Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Javadoc links to use OS version [DI-425] #1538

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Feb 12, 2025

The OS & EE Javadocs are versioned separately - reflecting the latest version of each product.
However in the documentation, we use the (problematic) full-version property when linking to the OS Javadoc which is the latest EE version.
We no longer publish (incorrectly versioned) OS Javadoc as part of an EE release which is why this problem is only now visible.

Replaced:

With https://docs.hazelcast.org/docs/{os-version}/javadoc as are all OS content.

Tested by running external link check on branch.

Ideally this should be backported to all maintenance branches, but the PR is unlikely to merge without conflicts. If required, re-applying the change (now it's scoped) is trivial.

Fixes: DI-425

@JackPGreen JackPGreen added the backport to all versions Backport commits to maintenance branches (from main) label Feb 12, 2025
@JackPGreen JackPGreen self-assigned this Feb 12, 2025
@JackPGreen JackPGreen requested a review from a team as a code owner February 12, 2025 22:07
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit dc3caf0
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/67ad1b91dc16aa0008a71405
😎 Deploy Preview https://deploy-preview-1538--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackPGreen JackPGreen added backport to 5.5 Backport commits from main to v/5.5 and removed backport to all versions Backport commits to maintenance branches (from main) labels Feb 13, 2025
Copy link
Contributor

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JackPGreen

@JackPGreen JackPGreen merged commit ba2bb1c into main Feb 13, 2025
5 of 6 checks passed
@JackPGreen JackPGreen deleted the Fix-Javadoc-Links branch February 13, 2025 08:59
JackPGreen added a commit to JackPGreen/hz-docs that referenced this pull request Feb 13, 2025
JackPGreen added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 5.5 Backport commits from main to v/5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants