Fix MC Docker tags #1539
Fix MC Docker tags #1539
Conversation
Update MC Docker tags to `hazelcast/management-center:{page-latest-supported-mc}`.
Updated from:
- `latest-snapshot` - should use released artefacts
- `full-version` - the versions of Hazelcast platform and MC are not tied (e.g. no `5.5.2` MC)
JackPGreen
added
the
backport to all versions
👷 Deploy Preview for hardcore-allen-f5257d processing.
|
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -613,7 +613,7 @@ In this step, you start a local instance of Management Center and use it to view | |||
| ---- | |||
| docker run \ | |||
| --network hazelcast-network \ | |||
| -p 8080:8080 hazelcast/management-center:latest-snapshot | |||
| -p 8080:8080 hazelcast/management-center:{page-latest-supported-mc} | |||
There was a problem hiding this comment.
These don't appear to resolve when used in code samples. The original text wasn't a variable - was that just a mistake, or is latest-snapshot a valid input to Docker? If so, I think this change breaks the procedure?
@oliverhowell FYI, seems like we might need a solution for handling variables in code blocks?
There was a problem hiding this comment.
Latest snapshot isn’t a valid tag (presumably any more). I didn’t actually test it in the deployment though - we could use latest instead?
There was a problem hiding this comment.
Looks like I’m wrong and it works (weird as I’m sure I test locally!) - https://hub.docker.com/layers/hazelcast/management-center/latest-snapshot/images/sha256-5182aec7dfc667ade16b61ef2cb7b49e5936950af2b8a6d9fcbd4a564e474bd5
still shouldn’t be a snapshot tho.
There was a problem hiding this comment.
And there is no latest… so if we can’t use substitution, maybe this is the best of a bad bunch?
There was a problem hiding this comment.
Possibly. Could you check with someone in MC Engineering?
As a separate task, it might be worth us searching the docs for variables inside code blocks (regex in the source files?) and/or broken variables on the site (IDK).
There was a problem hiding this comment.
Looks like attributes are filtered out by default (sensible), but you can add them back in? asciidoctor/asciidoctor#1741
There was a problem hiding this comment.
Looks like attributes are filtered out by default (sensible), but you can add them back in? asciidoctor/asciidoctor#1741
Great spot!
Possibly. Could you check with someone in MC Engineering?
I think this is a non-issue now the substitution works?
There was a problem hiding this comment.
As a separate task, it might be worth us searching the docs for variables inside code blocks (regex in the source files?) and/or broken variables on the site (IDK).
Good idea, tried but could only find hazelcast/clc-docs#50
I'm surprised this issue doesn't occur more often tbh.
Here was how I tested it btw - just a simple set of (hacky) commands to build the docs locally, and scrape the output text for anything in curly braces and then log it + where it was found:
npm install
npm run-script build-local
find test -name "*.html" | while read -r file; do
lynx -dump -listonly -nonumbers "${file}" | { grep --extended-regexp "\{[^}]*\}" && echo " in ${file}" || test $? = 1; }
done
There was a problem hiding this comment.
Great, thank you for sorting all that out.
I think this is a non-issue now the substitution works?
I might still expect someone in the relevant team to sign off this sort of change, but the most important thing is that the updated command is tested and we're not breaking anything.
| @@ -613,7 +613,7 @@ In this step, you start a local instance of Management Center and use it to view | |||
| ---- | |||
| docker run \ | |||
| --network hazelcast-network \ | |||
| -p 8080:8080 hazelcast/management-center:latest-snapshot | |||
| -p 8080:8080 hazelcast/management-center:{page-latest-supported-mc} | |||
There was a problem hiding this comment.
Great, thank you for sorting all that out.
I think this is a non-issue now the substitution works?
I might still expect someone in the relevant team to sign off this sort of change, but the most important thing is that the updated command is tested and we're not breaking anything.
Backport of #1539 Update MC Docker tags to `hazelcast/management-center:{page-latest-supported-mc}`. Updated from: - `latest-snapshot` - should use released artefacts - `full-version` - the versions of Hazelcast platform and MC are not tied (e.g. no `5.5.2` MC) Co-authored-by: Jack Green <[email protected]>
Backport of #1539 Update MC Docker tags to `hazelcast/management-center:{page-latest-supported-mc}`. Updated from: - `latest-snapshot` - should use released artefacts - `full-version` - the versions of Hazelcast platform and MC are not tied (e.g. no `5.5.2` MC) Co-authored-by: Jack Green <[email protected]>
Backport of #1539 Update MC Docker tags to `hazelcast/management-center:{page-latest-supported-mc}`. Updated from: - `latest-snapshot` - should use released artefacts - `full-version` - the versions of Hazelcast platform and MC are not tied (e.g. no `5.5.2` MC) Co-authored-by: Jack Green <[email protected]>
Update MC Docker tags to
hazelcast/management-center:{page-latest-supported-mc}.Updated from:
latest-snapshot- should use released artefactsfull-version- the versions of Hazelcast platform and MC are not tied (e.g. no5.5.2MC)