Remove more full-version usages
#1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`full-version` property is problematic as EE and OS are versioned separately, which can lead to broken references. _Where possible_ I've updated all `full-version` usages to be either OS or EE, covering the following scenarios: - Maven JAR version specifications (`pom.xml` or direct download links) - `hazelcast-jet-kafka` link was just broken (previously missed because the link isn't fully formed in the documentation) - packaging references (brew etc) - gradle references *Many* of the above were producing the wrong result in our current documentation (e.g. referencing `5.5.3` of Hazelcast OS in Maven which doesn't exist). One of the files also referenced a Jet artefact, but used the `full-version` - Jet hasn't been updated since `4.x` so didn't work. I've added a new property for the Jet version and have referenced that instead, although the content is probably outdated and needs updating.
JackPGreen
added
the
backport to all versions
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JackPGreen
added
backport to 5.5
oliverhowell
approved these changes
Feb 13, 2025
JackPGreen
added a commit
to JackPGreen/hz-docs
that referenced
this pull request
Feb 13, 2025
`full-version` property is problematic as EE and OS are versioned separately, which can lead to broken references. _Where possible_ I've updated all `full-version` usages to be either OS or EE, covering the following scenarios: - Maven JAR version specifications (`pom.xml` or direct download links) - `hazelcast-jet-kafka` link was just broken (previously missed because the link isn't fully formed in the documentation) - packaging references (brew etc) - gradle references *Many* of the above were producing the wrong result in our current documentation (e.g. referencing `5.5.3` of Hazelcast OS in Maven which doesn't exist). One of the files also referenced a Jet artefact, but used the `full-version` - Jet hasn't been updated since `4.x` so didn't work. I've added a new property for the Jet version and have referenced that instead, although the content is probably outdated and needs updating.
JackPGreen
added a commit
to JackPGreen/hz-docs
that referenced
this pull request
Feb 13, 2025
The new `jet-version` property added in hazelcast#1540 was used in the wrong place.
Merged
JackPGreen
added a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full-versionproperty is problematic as EE and OS are versioned separately, which can lead to broken references.Where possible I've updated all
full-versionusages to be either OS or EE, covering the following scenarios:pom.xmlor direct download links)hazelcast-jet-kafkalink was just broken (previously missed because the link isn't fully formed in the documentation)Many of the above were producing the wrong result in our current documentation (e.g. referencing
5.5.3of Hazelcast OS in Maven which doesn't exist).One of the files also referenced a Jet artefact, but used the
full-version- Jet hasn't been updated since4.xso didn't work. I've added a new property for the Jet version and have referenced that instead, although the content is probably outdated and needs updating.