Add Subfield 689$p #1973
Merged
Add Subfield 689$p #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acka47
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Integration tests have to be adjusted because of the added test file, see https://github.com/hbz/lobid-resources/actions/runs/8139656167/job/22243316186#step:8:865 following. It probably makes sense when @dr0i shows you what to do, @maipet.
Complements 633c383.
dr0i
approved these changes
Mar 4, 2024
|
To see what play ("web") tests have to be adapted: |
|
Will be deployed next Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1972