-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust urn regex #2035
adjust urn regex #2035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the web app tests for the new test data to fix the build.
Looking at the code I'm wondering if the match-regex shouldn't be the same as the replace-regex, to make sure it is actually replaced if it matches? But will assign @TobiasNx for proper functional review.
Functionally this looks good. Next time combine the changes in the Fix and the changes in the testfiles in one commit. Otherwise is this hint from @fsteeg a must? Is there a scneario where there is a urn without http?
Otherwise +1 |
We talked about it off board, lets try to create the urn and the resolver links differently: Fetch all urn from the links AND copy all urn links that are marked Resolver-System in $x without formatting except doi links. PS: Also we should add an URN Link if no URN Resolver System Link is added but an URN exists in 024 (added Aug 5th 24) |
I try to catch all URN Links except those repository links that are have a urn/urn pattern since they are not resolver links: http://digital.ub.uni-duesseldorf.de/urn/urn:nbn:de:hbz:061:1-249692 or https://sammlungen.ulb.uni-muenster.de/urn/urn:nbn:de:hbz:6-85659520092
@maipet I added some commits to better handle the URNs and Resolver Links. The links in 865 with Resolver System were already used but were skipped if they had a Additionally I have changed the URL for nbn links to org instead of de since that seems to be the standard. Could your review it? And also should we create a new PR with less commits? |
This pr is replaced by #2043 |
#2034