Switch from submodule "vocabs" to "lbz-vocabs" #2064
Conversation
We now use a dedicated vocabs repo for RPB. - add git submodule "lbz-vocabs" - improve README - configure start script
| fixVariables.put("rpb2.ttl", "../../../../../../vocabs/rpb/rpb2.ttl"); | ||
| fixVariables.put("rpb-spatial.ttl", "../../../../../../vocabs/rpb/rpb-spatial.ttl"); | ||
| fixVariables.put("rpb.ttl", "../../../../../../vocabs/rpb/rpb.ttl"); | ||
| fixVariables.put("rpb2.ttl", "../../../../../../lbz-vocabs/rpb/rpb2.ttl"); |
There was a problem hiding this comment.
This file will finally most probably be renamed to lbz-notationen.ttl, see hbz/lbz-vocabs@38b3e89
There was a problem hiding this comment.
This means, we should wait with mergin this until hbz/lbz-vocabs#6 is merged and adjust the file name if necessary.
There was a problem hiding this comment.
I have made a separate PR for changing the file name at hbz/lbz-vocabs#7 so that we can move on with this PR. @TobiasNx will review over there.
|
I also adjusted the filenames and mappings. |
There was a problem hiding this comment.
+1 This looks good. It can and should be merged now as the lbz vocabs are now removed from lobid-vocabs with hbz/lobid-vocabs#230
|
@acka, you wrote:
This PR is asigned to you still. Who is going to merge this? Would you assign me, if that is what you want? |
| fixVariables.put("rpb.ttl", "../../../../../../vocabs/rpb/rpb.ttl"); | ||
| fixVariables.put("lbz-notationen.ttl", "../../../../../../lbz-vocabs/rpb/lbz-notationen.ttl"); | ||
| fixVariables.put("rpb-spatial.ttl", "../../../../../../lbz-vocabs/rpb/rpb-spatial.ttl"); | ||
| fixVariables.put("rpb.ttl", "../../../../../../lbz-vocabs/rpb/rpb.ttl"); |
There was a problem hiding this comment.
There is no rpb directory in https://github.com/hbz/lbz-vocabs . I guess that rpb-subdirectory has just to be removed here?
We now use a dedicated vocabs repo for RPB.
See #2063.