Add workaround if cataloguing dates in 008 that are too long #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some records have 8 instead of 6 digits. I talked to @maipet we decided that ignoring 8 digits due to invalid 008/00-05 is better than constructing values from the invalid date.
maipet
approved these changes
Jan 7, 2025
|
@dr0i this should fix the mapper parser exception. The error was due to errors in cataloguing. Some records provided 8 instead of 6 digits which is not valid with regard to 008 marc documentation. @maipet and i decided not to construct dates out of 8 digits since they are not valid and then use the fallback from MGN instead. |
dr0i
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #2114 (comment) some issues popped up with cataloguing dates that are too long consisting of 8 instead of 6 digits.
Since 008/06 should not be an digit I have introduced a workaround if the date is to long.
@maipet can you have a look if this workaround makes sense?
Thanks.