Reduce usage of EtikettMaker #2106 #2123
Conversation
|
@dr0i can you have a look at this? I reduced all Ettiket Maker usage to the context and labels for undefined uris. |
| @@ -109,7 +109,7 @@ | |||
| "label" : "Mystik & Aszese des 16.-19. Jahrhunderts [Nationallizenz]", | |||
| "type" : [ "Collection" ] | |||
| }, { | |||
| "id" : "https://lobid.org/collections#NLZ", | |||
| "id" : "http://lobid.org/collections#NLZ", | |||
| "type" : [ "Collection" ], | |||
There was a problem hiding this comment.
If possible we should stick to https. Even more so if this was so before. Or do you have an argument that support your deliberately switching this?
There was a problem hiding this comment.
I was remembering: #1343 (comment)
That we had to switch back to http instead of https.
And thought this was an error on our side.
Then I checked:
aleph.lobid.org/resources/TT050372336.json
lobid-resources/src/main/resources/morph-hbz01-to-lobid.xml
Lines 7285 to 7289 in 7f982c1
It seems to have used https for the collection URIs.
I roll back this change then.
There was a problem hiding this comment.
I adjusted it as requested.
| }, | ||
| "role" : { | ||
| "id" : "http://id.loc.gov/vocabulary/relators/http://id.loc.gov/vocabulary/relators/edt", | ||
| "label" : "edt" |
There was a problem hiding this comment.
ah, this PR also seems to fix a broken id 👍
For more context see: #2123 (comment)
I migrated some label maps to fix and use them via lookup as filemaps there.
Also I deleted all unnecessary labels that already were provided by the fix.
While doing that I adjusted the lobid uri for collections to http (since all lobid uris we use are http) and fixed an error while mapping marc relator infos.