Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to the conditional models #36

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Corrections to the conditional models #36

merged 2 commits into from
Jan 28, 2025

Conversation

AntoinePTJ
Copy link
Contributor

  • addition of config.cast for the SelfAttentionConfig and CrossAttentionConfig in ConditionalGATr
  • addition of ConditionalGATr, ConditionalGATrBlock and CrossAttention in the init files
  • addition of ConditionalTransformer to the baseline models
  • correction of the checkpoints in BaselineTransformers

spinjo
spinjo requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@spinjo spinjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some minor comments, afterwards I'm happy to merge 🚀

experiments/baselines/conditional_transformer.py Outdated Show resolved Hide resolved
experiments/baselines/transformer.py Show resolved Hide resolved
experiments/baselines/conditional_transformer.py Outdated Show resolved Hide resolved
@spinjo spinjo merged commit dad358f into heidelberg-hepml:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spinjo spinjo spinjo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoinePTJ @spinjo