address review comments

helium · Dec 11, 2023 · 3f59243 · 3f59243
1 parent 7a1475c
commit 3f59243
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/mobile_config/migrations/5_carrier_service.sql b/mobile_config/migrations/5_carrier_service.sql
@@ -1,7 +1,6 @@
 create table carrier_keys (
-    pubkey text not null,
+    pubkey text primary key not null,
     entity_key text not null,
     created_at timestamptz not null default now(),
-    updated_at timestamptz not null default now(),
-    PRIMARY KEY(pubkey)
+    updated_at timestamptz not null default now()
 );
diff --git a/mobile_verifier/src/reward_shares.rs b/mobile_verifier/src/reward_shares.rs
@@ -218,15 +218,15 @@ impl ServiceProviderShares {
         payer_shares: HashMap<String, u64>,
         client: &dyn CarrierServiceVerifier<Error = ClientError>,
     ) -> anyhow::Result<ServiceProviderShares> {
-        let mut shares = vec![];
+        let mut sp_shares = ServiceProviderShares::default();
         for (payer, total_dcs) in payer_shares {
             let service_provider = Self::payer_key_to_service_provider(&payer, client).await?;
-            shares.push(ServiceProviderDataSession {
+            sp_shares.shares.push(ServiceProviderDataSession {
                 service_provider,
                 total_dcs: Decimal::from(total_dcs),
             })
         }
-        Ok(ServiceProviderShares { shares })
+        Ok(sp_shares)
     }
 
     fn total_dc(&self) -> Decimal {

diff --git a/reward_index/src/indexer.rs b/reward_index/src/indexer.rs
@@ -32,6 +32,7 @@ pub enum RewardType {
     IotGateway,
     IotOperational,
     MobileSubscriber,
+    MobileServiceProvider,
 }
 
 #[derive(Debug, Clone, PartialEq, Eq, Hash)]
@@ -157,7 +158,7 @@ impl Indexer {
                             Ok((
                                 RewardKey {
                                     key: sp.as_str_name().to_string(),
-                                    reward_type: RewardType::MobileSubscriber,
+                                    reward_type: RewardType::MobileServiceProvider,
                                 },
                                 r.amount,
                             ))