guard unallocated sp reward writeout

helium · Nov 14, 2023 · 87f6ce3 · 87f6ce3
1 parent 259da36
commit 87f6ce3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/mobile_verifier/src/reward_shares.rs b/mobile_verifier/src/reward_shares.rs
@@ -286,7 +286,7 @@ impl ServiceProviderShares {
             })
     }
 
-    pub fn unallocated_reward(
+    pub fn into_unallocated_reward(
         unallocated_amount: Decimal,
         reward_period: &'_ Range<DateTime<Utc>>,
     ) -> anyhow::Result<proto::MobileRewardShare> {

diff --git a/mobile_verifier/src/rewarder.rs b/mobile_verifier/src/rewarder.rs
@@ -245,12 +245,16 @@ where
 
         // write out any unallocated service provider reward
         let unallocated_sp_reward_amount = total_sp_rewards - Decimal::from(allocated_sp_rewards);
-        let unallocated_sp_reward =
-            ServiceProviderShares::unallocated_reward(unallocated_sp_reward_amount, reward_period)?;
-        self.mobile_rewards
-            .write(unallocated_sp_reward, [])
-            .await?
-            .await??;
+        if unallocated_sp_reward_amount > dec!(0) {
+            let unallocated_sp_reward = ServiceProviderShares::into_unallocated_reward(
+                unallocated_sp_reward_amount,
+                reward_period,
+            )?;
+            self.mobile_rewards
+                .write(unallocated_sp_reward, [])
+                .await?
+                .await??;
+        }
 
         let written_files = self.mobile_rewards.commit().await?.await??;