Update file_info_poller to track a process name and make sqlx an optional dependency #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bbalser
commented
Dec 16, 2023
•
bbalser
commented
- Add process_name, defaulted to 'default', to file_info_poller to allow 2 instances reading the same source data to completely independent of each other.
- Added traits and feature(sqlx-postgres) to make sqlx an optional dependency of the file-store crate
| @@ -57,3 +57,4 @@ tempfile = "3" | |||
|
|
|||
| [features] | |||
| local = ["aws-types"] | |||
| sqlx-postgres = ["sqlx"] | |||
There was a problem hiding this comment.
does this make the option dependency "on" by default? might want to add that and then allow the default-features :false ?
so under [features] add the line default = ["sqlx-postgres"] and then you can remove the feature-enabling changes to all of the other cargo.toml files
andymck
approved these changes
Dec 18, 2023
maplant
reviewed
Dec 18, 2023
maplant
approved these changes
Dec 18, 2023
bbalser
force-pushed
the
bbalser/file-info-poller-updates
branch
from
ed2b337 to
10ddea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.