-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Provider Promotions again #877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
requested review from
madninja,
macpie,
andymck,
bbalser and
jeffgrunewald
October 17, 2024 21:30
michaeldjeffrey
force-pushed
the
mj/service-provider-promotions-v2
branch
2 times, most recently
from
October 17, 2024 22:12
8d519bd
to
4fbc63a
Compare
andymck
approved these changes
Oct 18, 2024
bbalser
approved these changes
Oct 23, 2024
We now get incentive fund bps and active promotions from mobile-config list incentive promotions from mobile-config client
sp_promotions needs to be written to the reward manifest. If we pull it up a level, we can uncouple service provider rewards from carrier_client and the database.
Fill out query to return all active service provider promotions
michaeldjeffrey
force-pushed
the
mj/service-provider-promotions-v2
branch
from
October 29, 2024 16:25
0de3606
to
e60c50e
Compare
michaeldjeffrey
force-pushed
the
mj/service-provider-promotions-v2
branch
from
October 29, 2024 17:09
f663c8d
to
c9ba2ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto PR :: helium/proto#424
Please scrutinize the names.
Previously
incentive_escrow_fund_bps
was stored in Solana, and written to s3.Now
incentive_escrow_fund_bps
and promotions are stored in themetadata_db
.Temporary
metadata_db
table creationI am testing with a local table until incentive programs make it into the metadata_db proper.
Using the Column mapping and Account Structure I have the following table.