Have location tracking in mobile-config track #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
force-pushed
the
mobile-config-tracker-asserted_at
branch
from
758bdaf to
02a3651
Compare
bbalser
reviewed
Dec 4, 2024
bbalser
reviewed
Dec 4, 2024
| @@ -86,17 +88,23 @@ impl TrackedMobileRadio { | |||
| hash: radio.hash(), | |||
| last_changed_at: radio.refreshed_at, | |||
| last_checked_at: Utc::now(), | |||
| asserted_location: radio.location, | |||
| asserted_location_change_at: None, | |||
There was a problem hiding this comment.
What is the thinking about making this None? The first time we see a radio, this field will be null and how do you envision clients working with it?
There was a problem hiding this comment.
What is the thinking about making this None?
My logic is next: At the beginning it is None because we don't have information about previous time when asserted_location was changed.
The first time we see a radio, this field will be null and how do you envision clients working with it?
I expect clients (or functions that use tracked mobile radio table) will handle None by their own logic.
Otherwise, if we hardcode some value here, we don't give an option for the clients.
bbalser
reviewed
Dec 4, 2024
michaeldjeffrey
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional feature to previous PR: #902