Refactor file store constructor #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
force-pushed
the
file-store-local-support
branch
from
fa0dce2 to
5dc157f
Compare
kurotych
force-pushed
the
file-store-local-support
branch
from
5dc157f to
9349c44
Compare
michaeldjeffrey
approved these changes
Dec 13, 2024
bbalser
approved these changes
Dec 14, 2024
jeffgrunewald
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to #911
Actually it is not only refactoring but also providing "local" feature to the
newfunction (what I was missed in previous PR)