-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java options for a correct generation #295
base: master
Are you sure you want to change the base?
Changes from 1 commit
ee0e9df
18de7e8
de2e728
7a71918
4cebb99
dc10a8a
1cf1519
597e5e9
5c81cfa
0625b9c
43f62ba
7594329
1a8322a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
syntax = "proto3"; | ||
|
||
package helium; | ||
option java_package = "xyz.nova.grpc"; | ||
option java_outer_classname = "regionparam"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, the generation is not working properly when you name it correctly. I do not remind the detail of the problem but it was not working with camelcase and upfront uppercase There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how was the problem exhibited? At build time? If so, I would still like to see a CI step, just like we do for all other supported languages |
||
option java_multiple_files = true; | ||
|
||
message blockchain_region_params_v1 { | ||
repeated blockchain_region_param_v1 region_params = 1; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rename this to
com.helium.*
please? This repo is in the foundation GitHub team