Add rewarded token type enum to {subdao}_reward_data in reward manifest #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two enum are needed so the default value for each reward_data type can be the corresponding subdao token for historical files that do not have these fields. Ref: HIP-138 https://github.com/helium/HIP/blob/main/0138-return-to-hnt.md Rewards will no longer be output in subdao tokens, only HNT.
michaeldjeffrey
force-pushed
the
mj/hip-138-reward-token
branch
from
79bf0f8 to
b4e4bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two enum are needed so the default value for each reward_data type can be the corresponding subdao token for historical files that do not have these fields.
Ref: HIP-138 https://github.com/helium/HIP/blob/main/0138-return-to-hnt.md
Rewards will no longer be output in subdao tokens, only HNT.
These fields are in the reward_manifest because they are part of the metadata of the rewards.