Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(commands)!: change arg handling strategy #12441

Closed
wants to merge 38 commits into from
+2,021 −819
Closed

refactor(commands)!: change arg handling strategy #12441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ff980a1
refactor(shellwords): change arg handling strategy
RoloEdits Jul 12, 2024
4cb2f80
feat: add a params range hint to `TypableCommand`
RoloEdits Jan 6, 2025
c224387
refactor: transition to a Vec wrapper for Args
RoloEdits Jan 7, 2025
e92b17e
refactor: add a signature field to TypableCommands
RoloEdits Jan 7, 2025
a72436a
refactor: propgate `ParseMode` to command signature
RoloEdits Jan 7, 2025
0aa7fdd
refactor: tweak Shellwords -> Args flow
RoloEdits Jan 7, 2025
e45a46f
refactor: make `unescaped` private
RoloEdits Jan 7, 2025
c537874
test: add base variant
RoloEdits Jan 7, 2025
4d594b5
fix: only validate argument count when enacting command
RoloEdits Jan 7, 2025
bde4c6c
doc: fix examples
RoloEdits Jan 7, 2025
17202ec
refactor: tidy up the file
RoloEdits Jan 7, 2025
7f53db5
refactor: add typestate to `ArgsParser` around unescaping rules
RoloEdits Jan 8, 2025
f09a495
refactor: tweak invalid param count error messages
RoloEdits Jan 8, 2025
c54a26b
refactor: remove uneeded From conversions
RoloEdits Jan 8, 2025
bf34167
docs: add suggested changes
RoloEdits Jan 8, 2025
94a7556
refactor: remove elided lifetime
RoloEdits Jan 8, 2025
a5850d5
feat: create `args` module
RoloEdits Jan 8, 2025
9a21fa3
doc: mention backtick unescaping
RoloEdits Jan 8, 2025
25886eb
refactor: move `Signature` to `args` module
RoloEdits Jan 8, 2025
55e3f0a
fix: doctests
RoloEdits Jan 8, 2025
53aa43b
refactor: remove command arg checks where possible
RoloEdits Jan 8, 2025
06012b4
fix: unused lints
RoloEdits Jan 8, 2025
e999a0d
refactor: tidy up nits
RoloEdits Jan 8, 2025
02acb6c
fix: remove uneeded style/space edits
RoloEdits Jan 8, 2025
32f8040
refactor: use enum instead of typestate for `ArgsParser`
RoloEdits Jan 9, 2025
910dfa6
fix: completer showing previous argument after space
RoloEdits Jan 10, 2025
81070da
fix: add special case if last char is `\`
RoloEdits Jan 10, 2025
08b4dd6
feat: add final remaining two ParserMode variants
RoloEdits Jan 10, 2025
fb3b6b7
reafactor: address more nits
RoloEdits Jan 10, 2025
b1b1e52
refactor: change default `ParseMode` to `Raw`
RoloEdits Jan 10, 2025
1dd8001
fix: check for end quote in ends_with_whitespace
RoloEdits Jan 10, 2025
b1b8b03
fix: separate filepath parsing mode between unix and windows
RoloEdits Jan 10, 2025
9af8a7b
fix: pass `Option<&str>` to yank_join_impl instead of `&str`
RoloEdits Jan 11, 2025
31194a0
feat: add manual `default` function to `ParseMode`
RoloEdits Jan 11, 2025
22d6d66
refactor: name arguments in `debub_remote` better
RoloEdits Jan 11, 2025
4660350
refactor: change toggle and set ParseMode to `default`
RoloEdits Jan 11, 2025
fc05f8b
refactor: verify `ensure_signature` positionals for all `ParseMode` k…
RoloEdits Jan 11, 2025
c7c1132
test: change name to better describe test
RoloEdits Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading