Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at refactor for insights #1748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pims
Copy link
Contributor

@pims pims commented Aug 26, 2016

⚠️ Don't merge this.

cc @jykfan @jarred-h

@pims pims force-pushed the tim-insights-refactor branch from b18d118 to 863cd76 Compare August 26, 2016 21:47
@jykfan
Copy link
Contributor

jykfan commented Aug 26, 2016

@pims is the intention of GlobalProcessor to eventually also take care of questions processing as well?

(might be nice to have a single processor for both questions and insights, to allow for specific question n days after a specific insight, or vice versa)

@pims
Copy link
Contributor Author

pims commented Aug 26, 2016

@jykfan not at the moment. Insights and questions are different. And there is no Processor anymore, if its job is to schedule something, it's a scheduler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants