Add check is enabled in send massage #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2018 17:46
nkovacs
requested changes
Mar 7, 2018
| @@ -137,16 +143,28 @@ private function registerAssets() | |||
|
|
|||
| public function captureMessage($message, $params, $levelOrOptions = [], $stack = false, $vars = null) | |||
| { | |||
| if (!$this->enabled) { | |||
| Yii::trace(Json::encode([$message, $params, $levelOrOptions]), __CLASS__); | |||
There was a problem hiding this comment.
Yii::trace is deprecated, please use Yii::debug.
There was a problem hiding this comment.
All those who use Yii2.0.13 will not be able to use this extension. I propose to correct this problem, and only then do support 2.0.14
src/Component.php
Outdated
| @@ -106,7 +112,7 @@ private function setRavenClient() | |||
| } elseif (!is_object($this->client) || $this->client instanceof Closure) { | |||
| $this->client = Yii::createObject($this->client); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Remove this trailing whitespace please.
src/Component.php
Outdated
| @@ -137,16 +143,28 @@ private function registerAssets() | |||
|
|
|||
| public function captureMessage($message, $params, $levelOrOptions = [], $stack = false, $vars = null) | |||
| { | |||
| if (!$this->enabled) { | |||
| Yii::trace(Json::encode([$message, $params, $levelOrOptions]), __CLASS__); | |||
| return '-1'; | |||
There was a problem hiding this comment.
captureMessage normally returns the event id as a string, but it can also return null according to its doc.
We should also return null if the component is not enabled.
albertborsos
reviewed
Mar 7, 2018
src/Component.php
Outdated
| return $this->client->captureMessage($message, $params, $levelOrOptions, $stack, $vars); | ||
| } | ||
|
|
||
| public function captureException($exception, $culpritOrOptions = null, $logger = null, $vars = null) | ||
| { | ||
| if (!$this->enabled) { | ||
| Yii::trace(Json::encode([$message, $params, $levelOrOptions]), __CLASS__); |
There was a problem hiding this comment.
+1 there is no $message, $params and $levelOrOptions variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sentry module disabled and i call \Yii::$app->sentry->captureMessage