Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QR for non tall-skinny matrices and split=0 #1744

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add QR for non tall-skinny matrices and split=0 #1744

wants to merge 12 commits into from

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Dec 9, 2024 •
edited
Loading

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

see title

Issue/s resolved: #1736

Does this change modify the behaviour of other functions? If so, which?

no

@mrfh92 mrfh92 marked this pull request as ready for review December 9, 2024 16:39
@mrfh92 mrfh92 added linalg ESAPCA relevant for the ESA-funded project "ESAPCA" labels Dec 9, 2024
@mrfh92 mrfh92 self-assigned this Dec 9, 2024
@mrfh92 mrfh92 added the enhancement New feature or request label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for the PR!

Hoppe added 2 commits December 10, 2024 10:18
debugging
3a77070
Merge branch 'features/1736-QR_for_non-tall-skinny_matrices_and_split…
b6bd730 
…=0' of github.com:helmholtz-analytics/heat into features/1736-QR_for_non-tall-skinny_matrices_and_split=0
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (64ea1c6) to head (3465c7c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
+ Coverage   92.24%   92.26%   +0.01%     
==========================================
  Files          84       84              
  Lines       12460    12486      +26     
==========================================
+ Hits        11494    11520      +26     
  Misses        966      966
Flag Coverage Δ
unit 92.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 mentioned this pull request Dec 10, 2024
Open
6 tasks
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Dec 10, 2024

needs to be merged before #1697

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 added the PR talk label Dec 16, 2024
@ClaudiaComito ClaudiaComito changed the title QR for non tall-skinny matrices and split=0 Add QR for non tall-skinny matrices and split=0 Jan 13, 2025
@github-actions github-actions bot added core features testing Implementation of tests, or test-related issues labels Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

ClaudiaComito
ClaudiaComito reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mrfh92, great to have this, I only have a few minor comments.

Hakdag97
Hakdag97 previously approved these changes Jan 20, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Feb 14, 2025 •
edited
Loading

@JuanPedroGHM Is there currently a problem with the benchmark workflow or is that an error in the PR?

It looks like that the error is the following:

slurmstepd: error: execve(): perun: No such file or directory

@mrfh92 mrfh92 added the PR talk label Feb 14, 2025
@ClaudiaComito ClaudiaComito added this to the 1.6 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaudiaComito ClaudiaComito Awaiting requested review from ClaudiaComito

@Hakdag97 Hakdag97 Awaiting requested review from Hakdag97

At least 1 approving review is required to merge this pull request.

Assignees

@mrfh92 mrfh92

Labels
benchmark PR benchmarking core enhancement New feature or request ESAPCA relevant for the ESA-funded project "ESAPCA" features linalg PR talk testing Implementation of tests, or test-related issues
Projects
Roadmap
Status: In Progress
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

QR for non-tall-skinny matrices and split=0
4 participants
@mrfh92 @ClaudiaComito @Hakdag97 @JuanPedroGHM