Migrates onNotification to stream unwrapped Notification

heroiclabs · Feb 18, 2023 · cda06e3 · cda06e3
1 parent a05e56a
commit cda06e3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 * **Breaking:** Renamed `ChannelJoinType` enum to `ChannelType`
 * **Breaking:** Renamed `leaderboardId` parameter to `leaderboardName` in `writeLeaderboardRecord` and `deleteLeaderboardRecord`
+* **Breaking:** `onNotifications` is now a `Stream<Notification>` instead of `Stream<List<Notification>>`
 * Added `onPartyData` stream to realtime client
 * Added `listTournamentRecordsAroundOwner` to client
 

diff --git a/lib/src/nakama_websocket_client.dart b/lib/src/nakama_websocket_client.dart
@@ -52,11 +52,9 @@ class NakamaWebsocketClient {
   Stream<MatchPresenceEvent> get onMatchPresence =>
       _onMatchPresenceController.stream;
 
-  final _onNotificationsController =
-      StreamController<List<Notification>>.broadcast();
+  final _onNotificationsController = StreamController<Notification>.broadcast();
 
-  Stream<List<Notification>> get onNotifications =>
-      _onNotificationsController.stream;
+  Stream<Notification> get onNotifications => _onNotificationsController.stream;
 
   final _onStatusPresenceController =
       StreamController<StatusPresenceEvent>.broadcast();
@@ -226,10 +224,10 @@ class NakamaWebsocketClient {
             return _onMatchPresenceController.add(MatchPresenceEvent.fromDto(
                 receivedEnvelope.matchPresenceEvent));
           case rtpb.Envelope_Message.notifications:
-            return _onNotificationsController.add(receivedEnvelope
-                .notifications.notifications
+            receivedEnvelope.notifications.notifications
                 .map((e) => Notification.fromDto(e))
-                .toList(growable: false));
+                .forEach((element) => _onNotificationsController.add(element));
+            return;
           case rtpb.Envelope_Message.statusPresenceEvent:
             return _onStatusPresenceController.add(StatusPresenceEvent.fromDto(
                 receivedEnvelope.statusPresenceEvent));