fix: correctly handling CLI errors again. #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandagg
commented
Aug 31, 2023
ryandagg
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
ryandagg
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
ryandagg
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
ryandagg
commented
Aug 31, 2023
| @@ -1,5 +1,5 @@ | |||
| import {Command, flags} from '@heroku-cli/command-v9' | |||
| import {DynoSizeCompletion, ProcessTypeCompletion} from '@heroku-cli/command/lib/completions' | |||
| import {DynoSizeCompletion, ProcessTypeCompletion} from '@heroku-cli/command-v9/lib/completions' | |||
There was a problem hiding this comment.
This didn't appear to have any impact, but cleaning up.
johlym
approved these changes
Sep 1, 2023
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2466
Likely #2471 as well.
Revert to standard error handling within the CLI while maintaining error reporting & telemetry.