feat: use internal http server not default mux (#13)

* use internal http server not default mux * change config * rename option * rename option
hertz-contrib · Jan 22, 2025 · 44ddd1d · 44ddd1d
1 parent 5297e2a
commit 44ddd1d
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 11 deletions.
diff --git a/options.go b/options.go
@@ -35,19 +35,21 @@ func (fn option) apply(cfg *config) {
 }
 
 type config struct {
-	buckets            []float64
-	enableGoCollector  bool
-	registry           *prom.Registry
-	runtimeMetricRules []collectors.GoRuntimeMetricsRule
-	disableServer      bool
+	buckets             []float64
+	enableGoCollector   bool
+	registry            *prom.Registry
+	runtimeMetricRules  []collectors.GoRuntimeMetricsRule
+	disableServer       bool
+	useDefaultServerMux bool
 }
 
 func defaultConfig() *config {
 	return &config{
-		buckets:           defaultBuckets,
-		enableGoCollector: false,
-		registry:          prom.NewRegistry(),
-		disableServer:     false,
+		buckets:             defaultBuckets,
+		enableGoCollector:   false,
+		registry:            prom.NewRegistry(),
+		disableServer:       false,
+		useDefaultServerMux: true,
 	}
 }
 
@@ -89,3 +91,10 @@ func WithRegistry(registry *prom.Registry) Option {
 		}
 	})
 }
+
+// WithDefaultServerMux use http.DefaultServeMux
+func WithDefaultServerMux(useDefault bool) Option {
+	return option(func(cfg *config) {
+		cfg.useDefaultServerMux = useDefault
+	})
+}
diff --git a/trace.go b/trace.go
@@ -84,9 +84,13 @@ func NewServerTracer(addr, path string, opts ...Option) tracer.Tracer {
 	}
 
 	if !cfg.disableServer {
-		http.Handle(path, promhttp.HandlerFor(cfg.registry, promhttp.HandlerOpts{ErrorHandling: promhttp.ContinueOnError}))
+		httpServer := http.DefaultServeMux
+		if !cfg.useDefaultServerMux {
+			httpServer = http.NewServeMux()
+		}
+		httpServer.Handle(path, promhttp.HandlerFor(cfg.registry, promhttp.HandlerOpts{ErrorHandling: promhttp.ContinueOnError}))
 		go func() {
-			if err := http.ListenAndServe(addr, nil); err != nil {
+			if err := http.ListenAndServe(addr, httpServer); err != nil {
 				hlog.Fatal("HERTZ: Unable to start a promhttp server, err: " + err.Error())
 			}
 		}()