Implement more input callbacks #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
emidoots
reviewed
Dec 21, 2024
| @@ -39,4 +39,8 @@ - (NSApplicationTerminateReply)applicationShouldTerminate:(NSApplication *)sende | |||
| return NSTerminateCancel; | |||
| } | |||
|
|
|||
| - (BOOL)applicationShouldTerminateAfterLastWindowClosed:(NSApplication *)sender { | |||
| return YES; | |||
| } | |||
There was a problem hiding this comment.
this seems a little sus to me; does it mean that when the user clicks the exit button on the last remaining window, the app won't get a chance to intercept/handle that event to decide if it wants to shutdown?
There was a problem hiding this comment.
Looks like applicationShouldTerminate() would still be called. But I'm not sure about returning NSTerminateCancel there. Makes it sound like the app couldn't close gracefully.
The terminate() docs look helpful
emidoots
reviewed
Dec 21, 2024
| _insertText_block = insertText_block; | ||
| } | ||
|
|
||
| - (void)setBlock_magnify:(void (^)(NSEvent *))magnify_block |
emidoots
reviewed
Dec 21, 2024
| [self interpretKeyEvents:@[ event ]]; | ||
| } | ||
|
|
||
| - (void)insertText:(id)string { |
There was a problem hiding this comment.
I guess we can implement image copy/paste in pixi now too maybe :)
emidoots
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all necessary new input related callbacks/functions to get pixi back working on macos with scrolling, mouse movement, buttons, etc.