Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on the road to refactor #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

on the road to refactor #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 80 additions & 45 deletions gilded_rose/lib/gilded_rose.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,77 +7,112 @@ defmodule GildedRose do
Enum.map(items, &update_item/1)
end

def decrease_quality(item, n) do
%{item | quality: max(0, item.quality - n)}
end

def increase_quality(item, n) do
%{item | quality: min(50, item.quality + n)}
end

def update_item(item) do
item = cond do
item.name != "Aged Brie" && item.name != "Backstage passes to a TAFKAL80ETC concert" ->
if item.quality > 0 do
item =
cond do
item.name == "some conjured item" ->
if item.name != "Sulfuras, Hand of Ragnaros" do
%{item | quality: item.quality - 1}
decrease_quality(item, 2)
else
item
end
else
item
end
true ->
cond do
item.quality < 50 ->
item = %{item | quality: item.quality + 1}
cond do
item.name == "Backstage passes to a TAFKAL80ETC concert" ->
item = cond do
item.sell_in < 11 ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}
true -> item
end
true -> item
end

item.name != "Aged Brie" && item.name != "Backstage passes to a TAFKAL80ETC concert" ->
if item.name != "Sulfuras, Hand of Ragnaros" do
decrease_quality(item, 1)
else
item
end

true ->
item = increase_quality(item, 1)

cond do
item.name == "Backstage passes to a TAFKAL80ETC concert" ->
item =
cond do
item.sell_in < 6 ->
item.sell_in < 11 ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}
true -> item

true ->
item
end
true -> item

true ->
item
end
true -> item
end
true -> item
end
end
item = cond do
item.name != "Sulfuras, Hand of Ragnaros" ->
%{item | sell_in: item.sell_in - 1}
true -> item
end

cond do
item.sell_in < 6 ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}

true ->
item
end

true ->
item
end

true ->
item
end

true ->
item
end

item =
cond do
item.name != "Sulfuras, Hand of Ragnaros" ->
%{item | sell_in: item.sell_in - 1}

true ->
item
end

cond do
item.sell_in < 0 ->
cond do
item.name != "Aged Brie" ->
cond do
item.name != "Backstage passes to a TAFKAL80ETC concert" ->
cond do
item.quality > 0 ->
cond do
item.name != "Sulfuras, Hand of Ragnaros" ->
%{item | quality: item.quality - 1}
true -> item
end
true -> item
item.name != "Sulfuras, Hand of Ragnaros" ->
decrease_quality(item, 1)

true ->
item
end
true -> %{item | quality: item.quality - item.quality}

true ->
decrease_quality(item, item.quality)
end

true ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}
true -> item

true ->
item
end
end
true -> item

true ->
item
end
end
end
17 changes: 14 additions & 3 deletions gilded_rose/test/gilded_rose_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,20 @@ defmodule GildedRoseTest do
]
end

test "some conjured item" do
assert GildedRose.update_quality([
%Item{name: "some conjured item", quality: 10, sell_in: 9}
]) == [
%Item{name: "some conjured item", quality: 8, sell_in: 8}
]

assert GildedRose.update_quality([
%Item{name: "some conjured item", quality: 1, sell_in: 9}
]) == [
%Item{name: "some conjured item", quality: 0, sell_in: 8}
]
end

test "Backstage passes" do
assert GildedRose.update_quality([
%Item{name: "Backstage passes to a TAFKAL80ETC concert", quality: 1, sell_in: 9}
Expand Down Expand Up @@ -68,8 +82,5 @@ defmodule GildedRoseTest do
%Item{name: "Aged Brie", quality: 50, sell_in: 8}
]
end

test "some conjured item" do
end
end
end