HBX-2840 Prevent Hibernate ORM from trying to load component classes #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koentsje
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HBX-2840
https://hibernate.atlassian.net/browse/HHH-18228
There were some changes in ORM that now are trying to load the component class to (e.g. to determine if it is a record or not) and since when the
org.hibernate.mapping.*model is built in Tools there are no classes yet ... we probably don't want ORM trying to load anything 🙈. My thinking here is... we probably don't really care about the component class so let's prevent ORM from loading things through classloaders by name, and just return a simpleObject.classso those ORM checks will pass through...Let me know what you think about such an approach 😃.