Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unboxing issue causing errors in acceptance tests #10375

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

kselveliev
Copy link
Contributor

Description:
After running acceptance tests against modularized web3 most of the web3 calls were failing.
This was caused by a subtle bug caused by unboxing of null Long in toAccountId method called by AccountReadableKVState. EntityId.of(id) fails with nullPointer when id is null.
Now just returning null if the id is null.
Reproduced with Then I call estimateGas with associate function for fungible token acceptance test.

  • ContractCallServicePrecompileModificationTest - adds test to verify calls are passing null auto renew account now.
  • EntityIdUtils - toAccountId(final Long) adds null check

Related issue(s):

Partially completes #10374

Notes for reviewer:
Acceptance tests are now more stable but still need additional adjustments to make all pass.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@kselveliev kselveliev added bug Type: Something isn't working web3 Area: Web3 API modularizedEVM labels Feb 13, 2025
@kselveliev kselveliev added this to the 0.124.0 milestone Feb 13, 2025
@kselveliev kselveliev self-assigned this Feb 13, 2025
@kselveliev kselveliev requested a review from a team as a code owner February 13, 2025 13:41
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (f82ab41) to head (df062b1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10375   +/-   ##
=========================================
  Coverage     92.18%   92.19%           
- Complexity     8094     8095    +1     
=========================================
  Files           988      988           
  Lines         33711    33713    +2     
  Branches       4264     4264           
=========================================
+ Hits          31078    31082    +4     
+ Misses         1618     1617    -1     
+ Partials       1015     1014    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 2cf94b9 into main Feb 13, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the 10374-acceptance-tests-fixes-modularized-v1 branch February 13, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working modularizedEVM web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants