-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unboxing issue causing errors in acceptance tests #10375
Fix unboxing issue causing errors in acceptance tests #10375
Conversation
Signed-off-by: Kristiyan Selveliev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10375 +/- ##
=========================================
Coverage 92.18% 92.19%
- Complexity 8094 8095 +1
=========================================
Files 988 988
Lines 33711 33713 +2
Branches 4264 4264
=========================================
+ Hits 31078 31082 +4
+ Misses 1618 1617 -1
+ Partials 1015 1014 -1 ☔ View full report in Codecov by Sentry. |
.../test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileModificationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
hedera-mirror-web3/src/main/java/com/hedera/services/utils/EntityIdUtils.java
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
After running acceptance tests against modularized web3 most of the web3 calls were failing.
This was caused by a subtle bug caused by unboxing of null Long in
toAccountId
method called byAccountReadableKVState
.EntityId.of(id)
fails with nullPointer when id is null.Now just returning null if the id is null.
Reproduced with
Then I call estimateGas with associate function for fungible token
acceptance test.ContractCallServicePrecompileModificationTest
- adds test to verify calls are passing null auto renew account now.EntityIdUtils
-toAccountId(final Long)
adds null checkRelated issue(s):
Partially completes #10374
Notes for reviewer:
Acceptance tests are now more stable but still need additional adjustments to make all pass.
Checklist