Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests in ContractCallSeviceTest class #10432

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Fix tests in ContractCallSeviceTest class #10432

merged 4 commits into from
Feb 21, 2025

Conversation

sdimitrov9
Copy link
Contributor

@sdimitrov9 sdimitrov9 commented Feb 19, 2025 •
edited
Loading

Fixing tests in ContractCallSeviceTest class, a payer was not set in some of the scenarios.

@sdimitrov9 sdimitrov9 self-assigned this Feb 19, 2025
@sdimitrov9 sdimitrov9 added the web3 Area: Web3 API label Feb 19, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 10 files with indirect coverage changes

@sdimitrov9 sdimitrov9 marked this pull request as ready for review February 20, 2025 16:19
@sdimitrov9 sdimitrov9 requested a review from a team as a code owner February 20, 2025 16:19
nickeynikolovv
nickeynikolovv previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@nickeynikolovv nickeynikolovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdimitrov9 sdimitrov9 force-pushed the Fix-ContractCallServiceTest-class-tests-10087 branch from 85d2012 to 22956da Compare February 21, 2025 12:36
@sdimitrov9 sdimitrov9 force-pushed the Fix-ContractCallServiceTest-class-tests-10087 branch from 22956da to 4cdf90e Compare February 21, 2025 14:38
@bilyana-gospodinova bilyana-gospodinova changed the title Fix tests in ContractcallSeviceTest class Fix tests in ContractCallSeviceTest class Feb 21, 2025
@kselveliev kselveliev self-requested a review February 21, 2025 14:42
bilyana-gospodinova
bilyana-gospodinova approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy added this to the 0.125.0 milestone Feb 21, 2025
@steven-sheehy steven-sheehy merged commit 7b3c84c into main Feb 21, 2025
31 checks passed
@steven-sheehy steven-sheehy deleted the Fix-ContractCallServiceTest-class-tests-10087 branch February 21, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@kselveliev kselveliev kselveliev approved these changes

@bilyana-gospodinova bilyana-gospodinova bilyana-gospodinova approved these changes

@nickeynikolovv nickeynikolovv nickeynikolovv left review comments

@xin-hedera xin-hedera Awaiting requested review from xin-hedera

@edwin-greene edwin-greene Awaiting requested review from edwin-greene

Assignees

@sdimitrov9 sdimitrov9

Labels
web3 Area: Web3 API
Projects
None yet
Milestone
0.125.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sdimitrov9 @steven-sheehy @nickeynikolovv @kselveliev @bilyana-gospodinova