Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to SPDX license header in Gradle #10445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change to SPDX license header in Gradle #10445

wants to merge 1 commit into from

Conversation

steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Feb 20, 2025 •
edited
Loading

  • Add license header to shell and yaml files
  • Apply formatting to some newly scanned files
  • Change docker compose to use an inline application.yml
  • Change spotless to use SPDX license header
  • Fix custom rosetta config in chart and compose
  • Fix custom rest config in compose
  • Remove unused scripts in rosetta

Part of #10362

Will follow up with a massive license header change PR

@steven-sheehy steven-sheehy added the enhancement Type: New feature label Feb 20, 2025
@steven-sheehy steven-sheehy added this to the 0.125.0 milestone Feb 20, 2025
@steven-sheehy steven-sheehy self-assigned this Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@steven-sheehy steven-sheehy marked this pull request as ready for review February 21, 2025 00:31
@steven-sheehy steven-sheehy requested review from a team as code owners February 21, 2025 00:31
andrewb1269hg
andrewb1269hg approved these changes Feb 21, 2025
View reviewed changes
Copy link

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve codecov.yml

xin-hedera
xin-hedera approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

edwin-greene
edwin-greene approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xin-hedera xin-hedera xin-hedera approved these changes

@edwin-greene edwin-greene edwin-greene approved these changes

@andrewb1269hg andrewb1269hg andrewb1269hg approved these changes

Assignees

@steven-sheehy steven-sheehy

Labels
enhancement Type: New feature
Projects
None yet
Milestone
0.125.0
Development

Successfully merging this pull request may close these issues.
4 participants
@steven-sheehy @xin-hedera @edwin-greene @andrewb1269hg