Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect issue #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexander-veit
Copy link
Member

This works for me locally. I am not sure why it worked before despite having homepageDemos": false. It should have always redirected to /app. Therefore, I am not 100% sure that this fix will work on higlass.io.

@flekschas
Copy link
Member

This will likely change custom docker builds. homepageDemos: false meant that the homepage is disabled for folks installing higlass on their own server.

The issue with the redirect is likely caused by changes to https://github.com/higlass/higlass-docker

@alexander-veit
Copy link
Member Author

alexander-veit commented Oct 29, 2020

Yeah, that makes sense. The only thing I found in higlass-docker concerning this is:
docker exec -it container-$STAMP-with-redis sed -i 's/HGAC_HOMEPAGE_DEMOS=false/HGAC_HOMEPAGE_DEMOS=true/' higlass-app/config.js in start_higlass_io.sh. Are we using this script?
Indeed, when I go into the docker container that is currently running on higlass.io, I see window.HGAC_HOMEPAGE_DEMOS=false; in higlass-app/config.js
Maybe we used this script before and now use only start_production.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants