Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【GLCC】Higress Console 支持通过表单配置 Wasm 插件 #322

Merged
merged 25 commits into from
Oct 25, 2024

Conversation

guluguluhhhh
Copy link
Contributor

draft of plugin forms

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@CH3CHO

This comment was marked as outdated.

backend/build.sh Outdated Show resolved Hide resolved
frontend/ice.config.mts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@CH3CHO
Copy link
Collaborator

CH3CHO commented Oct 5, 2024

建议兼容一下规范里的 scope 字段:https://higress.io/docs/latest/user/wasm-image-spec/ 。这个字段现在的名字不太对,后面会改成 x-scope。

https://github.com/higress-group/higress-group.github.io/pull/325/files

@CH3CHO

This comment was marked as resolved.

@guluguluhhhh

This comment was marked as resolved.

@CH3CHO

This comment was marked as resolved.

@guluguluhhhh

This comment was marked as resolved.

@CH3CHO CH3CHO marked this pull request as ready for review October 14, 2024 05:31
@CH3CHO CH3CHO requested a review from songpengyuan as a code owner October 14, 2024 05:31
@guluguluhhhh guluguluhhhh changed the title draft of plugin forms 【GLCC】Higress Console 支持通过表单配置 Wasm 插件 Oct 18, 2024
Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good.

CH3CHO

This comment was marked as resolved.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants