Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use failStrategy FAILED_OPEN in all generated WasmPlugin resources #363

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Nov 5, 2024

Ⅰ. Describe what this PR did

When user creates a new Wasm plugin config or updates an existed Wasm plugin config in the console, the failStrategy field in the generated WasmPlugin resource will be set to FAILED_OPEN.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni November 5, 2024 03:50
@CH3CHO CH3CHO requested a review from slievrly as a code owner November 5, 2024 03:50
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit f112a30 into higress-group:main Nov 5, 2024
4 checks passed
@CH3CHO CH3CHO deleted the fix/wasmplugin-failstrategy branch November 5, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants