Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Test Suite Integrity and Lint Compliance #133

Merged
merged 7 commits into from
Dec 1, 2024
Merged

Conversation

tgrecojs
Copy link
Contributor

@tgrecojs tgrecojs commented Dec 1, 2024

This PR focuses on technical debt reduction and codebase maintenance by ensuring all test suites are functioning as expected and maintaining code quality standards.

Key Changes:

  • Restored functionality to all existing test cases that were developed throughout the project lifecycle
  • Resolved test failures by implementing a local proposal file to handle deployment differences
  • Ensured all tests properly simulate production contract behavior
  • Fixed linting violations across the codebase
  • Verified successful execution of the complete test suite

Technical Notes:

  • Introduced airdrop.local.proposal.js for the purpose of working effectively with mocks provided by the Agoric SDK for testing.
  • Improved upon the execution of all tests via explicitly defining a timeout within the "ava" configuration (found in contract/package.json)
  • Updated test configurations to better align with production deployment patterns
  • All linting processes now exit with code 0 (no errors)

This maintenance work improves the reliability of our testing infrastructure and ensures our quality assurance processes remain robust.

- Update test suite to handle differences between production and test deployments
- Introduce local proposal file to manage side effects from SDK mocks
- Fix test environment configuration to match production contract behavior
- Added performance test files which are invoked with .skip by default
@tgrecojs tgrecojs merged commit 6ee922b into dev Dec 1, 2024
1 check passed
@tgrecojs tgrecojs deleted the tg-ci-fixes branch December 1, 2024 04:29
@tgrecojs
Copy link
Contributor Author

tgrecojs commented Dec 2, 2024

closes #134 #135 #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant