-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade docusaurus to v3.0.1 #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #566. This is a breaking change, for details see https://docusaurus.io/blog/releases/3.0
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Build is currently failing with:
I think some more changes are required to |
diwakergupta
added a commit
to hirosystems/stacks.js
that referenced
this pull request
Dec 20, 2023
For some reason, MDX is still unhappy about the code blocks (see hirosystems/docs#589) This fixes it, I'm not quite sure why though.
janniks
pushed a commit
to hirosystems/stacks.js
that referenced
this pull request
Dec 21, 2023
For some reason, MDX is still unhappy about the code blocks (see hirosystems/docs#589) This fixes it, I'm not quite sure why though.
rafaelcr
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566.
Description
This is a breaking change, for details see
https://docusaurus.io/blog/releases/3.0
Motivation for change?
Docusaurus v2.x is no longer supported and will be EOL in January.
What was changed?
Mostly just dependencies. Some markdown changes required to keep MDX3 happy.
Note that
_commands.md
is in a funky state - it's checked-in, but it is alsoauto-generated. My code block PR wasn't sufficient, I had to make some more changes
locally to keep the parser happy. These need to be propagated back to stacks.js.
Checklist