feat(113): add error and loading state to the main pages #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the login page - refactor error/loading flow - add tests - update translations
- reorganise tasks to accommodate for loading/error - refactor onboarding component - add tests - update translations
- add skeleton to bridge card - refactor layout and flow of bridge page - refactor bridge card for testing - add tests - add translations
- add translations - add skeletons for all data components - add tests - refactor flow of main page and tabs
- add translations - add skeletons for the editor - refactor flow of main page and tabs
vanch3d
force-pushed
the
fix/113/request-loading-error
branch
from
bb7c094 to
e421348
Compare
simon622
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
This PR adds the missing handlers for loading and error states to the main pages of the application, when data are being fetched
While data is being loaded, feedback is provided either by a loading spinner (e.g. login age) or by "skeleton" when visualising data.
Errors are indicated by inline alerts replacing the expected content.
Error and loading state are also preventing further interactions with the page (e.g. an error while loading the list of adapters prevents editing or creating a new adapter).
Note that all the data requests are cached by
React-Query. Covering loading and error in the main routing pages ensures that the expected data have been properly fetched by the time hooks are used further down the DOM tree.Login
Welcome
Bridges
Adapters
Namespace