refactor(27113): Ensure a single policy used in the Designer #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
requested review from
schaebo and
sfrehse
and removed request for
schaebo
- split group and tools - prevent policy node to be added if already in the canvas - fix styling and layout
- split group and tools - prevent policy node to be added if already in the canvas - fix styling and layout
vanch3d
force-pushed
the
refactor/27113/designer-single-policy
branch
from
38946ac to
e44bf36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/27113/details/
The PR refactors the designer's UX so that a single police node (either
Data PolicyorBehavior Policy) can be present in the canvas at a given time.The restriction applies to the loading of policies and to the creation of a new
draft: the toolbox is disabled when one of the two nodes is added, and the contextual connection (when a node is created by dragging a handle) cannot create a new node on drop.The PR also redesigns the toolbox to improve usability and accessibility, and also to make it more future-friendly (e.g. adding new construction inodes)
Out-of-scope
Before
After