fix(29788): Improve test coverage #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
changed the title
vanch3d
force-pushed
the
fix/29788/designer-test-coverage
branch
from
1141fa7 to
2ca8c5a
Compare
h2xd
approved these changes
Jan 28, 2025
vanch3d
force-pushed
the
fix/29788/designer-test-coverage
branch
from
2ca8c5a to
106e9d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/29788/details/
The PR improves significantly on test coverage, by adding missing tests on the
Data Hub Designerand refactoring some of the unit tests (files renamed to JS when JSX is not needed)Code coverage instrumentation (
nyc) and reports are also introduced forCypress. Note that the reports are generated for bothe2eandcomponenttesting but they overwrite each otherOut-fo-scope
CypressandVitestto get a full coverage analysis will be covered in a separate ticket