Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised English Translation of the Accessibility Statement #1765

Merged
merged 26 commits into from
Feb 12, 2025

Conversation

Caroline-Amanquah-HMCTS
Copy link
Collaborator

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/PRL-6915

Change description

English translation of accessibility page has been updated to align with the current requirements.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No

@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview February 3, 2025 13:43 Abandoned
<p class="govuk-body">{{ websiteAvailable | safe}}</p>
<p class="govuk-body">{{ websiteRanBy }}</p>
<p class="govuk-body">{{ asManyAsPossible }}</p>
{% set paragraphs = [websiteAvailable | safe, websiteRanBy, asManyAsPossible] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for creating array in njk file?

{% for paragraph in paragraphs %}
<p class="govuk-body">{{ paragraph }}</p>
{% endfor %}
{% set accessibilityOptions = [asManyAsPossibleColours, asManyAsPossibleZoom, asManyAsPossibleKeyboard, asManyAsPossibleSpeech, asManyAsPossibleListen] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for creating array in njk file?

<p class="govuk-body">{{ somePartsNot }}</p>
{% set notAccessibleParts = [somePartsNotDescriptiveness, somePartsNotText, somePartsNotPDF, somePartsNotWelsh, somePartsNotError] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for creating array in njk file?

<li>{{ email | safe }}</li>
<li>{{ accessibilityPhoneNumber }}</li>
</ul>
{% set improvements = [lookingToImprove | safe, improveAccessibility | safe] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for creating array in njk file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback Debolina,

In this update I have created the arrays shown in the njk file because the original template displayed multiple instances where paragraph and unordered list HTML tags were repeatedly written out with different content. Using the arrays enabled me to group the related content together that were within those tags and use the Nunjucks' {% for %} loop to iterate over each array, dynamically generate the required HTML.

This approach helps shorten the template and enables quicker content updates by simply modifying the arrays. Therefore, I was under the impression that this approach would be ideal.

However, I appreciate your insights and I am open to reverting the template to how it was originally or exploring any other suggestions you might have to improve the implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not in content.ts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the data on this page is static and used solely for display purposes, I found it more streamlined to reference the variables defined in the .ts file directly within the Nunjucks template also using arrays. This approach efficiently aligns the data presentation with the template’s layout without the complexities of manipulating data within the .ts file itself. I’m definitely open to suggestions if there's a more efficient method we could consider.

<li>{{ email | safe }}</li>
<li>{{ accessibilityPhoneNumber }}</li>
</ul>
{% set improvements = [lookingToImprove | safe, improveAccessibility | safe] %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not in content.ts?

@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview February 4, 2025 15:47 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview February 6, 2025 10:57 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview February 6, 2025 13:11 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview February 6, 2025 13:20 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview February 6, 2025 13:38 Abandoned
@shashisk97 shashisk97 merged commit 799cb74 into master Feb 12, 2025
3 checks passed
@shashisk97 shashisk97 deleted the feature/PRL-6915-accessibility-statement branch February 12, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants