Dtspb 4534 stop reason not to be used #3001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
hmcts-jenkins-j-to-z
bot
added
ns:probate
prd:probate
rel:probate-back-office-pr-3001
labels
| .ifPresent(value -> { | ||
| String userMessage = businessValidationMessageRetriever.getMessage( | ||
| "notAllowedStopReason", null, Locale.UK); | ||
| throw new BusinessValidationException(userMessage, userMessage); |
There was a problem hiding this comment.
is it worth adding a log statement here so we can see that these are getting rejected? (or does the exception handler already log this?)
There was a problem hiding this comment.
i think that fine, user will get the message on EXUI
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
tom-saunders-cts
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
DTSPB-4534
Change description
Does this PR introduce a breaking change? (check one with "x")